Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put role bypass check above channel override check #289

Merged

Conversation

@Numerlor
Copy link
Contributor

commented Oct 2, 2019

In the rewritten in_channel_check, if the command override was used, role bypass wouldn't take effect because the function would exit before it. This PR puts the bypass check above the override check to make sure the roles will bypass it.

…s can activate commands everywhere even with override channels specified
Copy link
Member

left a comment

Thanks for the quick fix. I've tested it and it works.

… the beginning of it
@Numerlor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Also added a fix for the last day of October not being completely included in the search query

@SebastiaanZ SebastiaanZ self-requested a review Oct 2, 2019
@sco1
sco1 approved these changes Oct 2, 2019
@sco1 sco1 merged commit 5b0a578 into python-discord:master Oct 2, 2019
2 checks passed
2 checks passed
Seasonal Bot Build #20191002.12 succeeded
Details
Seasonal Bot (Lint & Test) Lint & Test succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.