Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the issue and AoC commands to a superset of the global whitelist instead of bypassing it entirely #294

Merged
merged 6 commits into from Oct 14, 2019

Conversation

@Numerlor
Copy link
Contributor

commented Oct 3, 2019

Limits the issue and AoC command groups to the global whitelist + the seasonal bot chat and the AoC channel respectively

Closes: #293

@RohanRadia

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

Don't include the issues command in this for now. I am working on an updated issues command. Wait for it to be merged then update your PR please. Wait for #290 to merge then proceed with this if still needed.

@Numerlor Numerlor changed the title Limit the issue and AoC commands to a superset of the global whitelist insted of bypassing it entirely Limit the issue and AoC commands to a superset of the global whitelist instead of bypassing it entirely Oct 3, 2019
@sco1

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

There's no reason you can't merge the changes in if this PR is merged before yours.

@RohanRadia

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

There's no reason you can't merge the changes in if this PR is merged before yours.

Was just saying as I could sort it out in that PR but that is fair enough 👌

@sco1 sco1 added this to Needs review in Seasonalbot Tracking Oct 4, 2019
@sco1 sco1 added the area: bot core label Oct 4, 2019
Copy link
Member

left a comment

The in-channel overrides are not inherited by subcommands so they need to be explicitly defined.

This is also an issue with the hacktoberstats cog, it can be fixed with this PR

@Numerlor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

The in-channel overrides are not inherited by subcommands so they need to be explicitly defined.

This is also an issue with the hacktoberstats cog, it can be fixed with this PR

I was going to change the decorator to work on the cog level instead of per-command basis in a second PR after this one was merged, would it be alright to include it in here?

@sco1

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

The hackstats subcommands are currently broken in the additional whitelisted channels, so a fix should be included even if it's potentially temporary.

@Numerlor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

added the decorators to the whole hacktober command group

@Numerlor Numerlor requested a review from sco1 Oct 7, 2019
Copy link
Member

left a comment

seems like there's an inconsistent use of this decorator in the AoC and hacktoberfest cogs. please clarify - does this decorator work for both groups and individual commands? and if so, what's the rationale for not doing group overrides in both?

bot/seasons/christmas/adventofcode.py Show resolved Hide resolved
@lemonsaurus lemonsaurus dismissed sco1’s stale review Oct 14, 2019

seems to have been addressed.

Seasonalbot Tracking automation moved this from Needs review to Reviewer approved Oct 14, 2019
@lemonsaurus lemonsaurus merged commit c3dd57e into python-discord:master Oct 14, 2019
2 checks passed
2 checks passed
Seasonal Bot Build #20191014.1 succeeded
Details
Seasonal Bot (Lint & Test) Lint & Test succeeded
Details
Seasonalbot Tracking automation moved this from Reviewer approved to Done Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.