Use buttons for the bookmark command

[Diabolical5777]

Relevant Issues

Closes #932

Description

I replaced the reactions used currently with buttons

Did you:

• Join the Python Discord Community?
• Read all the comments in this template?
• Ensure there is an issue open, or link relevant discord discussions?
• Read and agree to the contributing guidelines?

[Robin5605]

It looks like we have a full on discord.ui.View subclass for a simple link button - but for the actual button that sends the bookmark in the DM, we're just doing:

view = discord.ui.View(timeout=TIMEOUT)
view.add_item(
    SendBookmark(self.action_bookmark, ctx.author, ctx.channel, target_message)
)

I think this should be flipped around. There's no need for a full fledged subclass for a simple link button, but maybe we can use a view subclass for the actual bookmark. I doubt we'll also need a button subclass since we're not doing anything dynamic

[Diabolical5777]

It looks like we have a full on discord.ui.View subclass for a simple link button - but for the actual button that sends the bookmark in the DM, we're just doing:

view = discord.ui.View(timeout=TIMEOUT)
view.add_item(
    SendBookmark(self.action_bookmark, ctx.author, ctx.channel, target_message)
)

I think this should be flipped around. There's no need for a full fledged subclass for a simple link button, but maybe we can use a view subclass for the actual bookmark. I doubt we'll also need a button subclass since we're not doing anything dynamic

I think you have it flipped. I used the button subclass for the button that is sent in the channel where the bookmark is invoked in so others can press the button. For the button in DM's that redirects to the bookmarked message, I used a view directly.

[Robin5605]

You're right that I had it flipped. The only other thing I might recommend we change is maybe subclassing discord.ui.View instead of a discord.ui.Button? Usually that's what we do for non-dynamic components. And I think all the parameters we pass into SendBookmark can be passed into the view subclass, and we shouldn't lose any functionality