Python 3.11#1226
Merged
Merged
Conversation
ChrisLovering
force-pushed
the
Python-3.11
branch
from
222270a to
c5a9307
Compare
shtlrs
approved these changes
Mar 4, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
A tiiiny nitpick:
update the build.yaml to build-deploy.yaml just so that it reflects what it does right off the bat
Other than that, this looks goud.
ChrisLovering
force-pushed
the
Python-3.11
branch
from
70de8ba to
8f8ab2d
Compare
wookie184
approved these changes
Mar 4, 2023
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
tried locally and through docker and seems to work fine 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Commit descriptions say it all.
Did you: