Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the landing page text #272

Merged
merged 6 commits into from Oct 11, 2019

Conversation

@lemonsaurus
Copy link
Member

commented Oct 1, 2019

The new text was written by Tizzysaurus in his website cleanup project, and lifted from his google doc.

If we're gonna improve this text, we may as well get some reviews going for the new text. Maybe there are entire sections that should be replaced, maybe it's missing something, or maybe this is fine.

The new text was written by Tizzysaurus in his website cleanup
project, and lifted from his google doc.
pydis_site/templates/home/index.html Outdated Show resolved Hide resolved
pydis_site/templates/home/index.html Outdated Show resolved Hide resolved
pydis_site/templates/home/index.html Outdated Show resolved Hide resolved
pydis_site/templates/home/index.html Outdated Show resolved Hide resolved
Makes various minor changes to commas and formulations.
@lemonsaurus

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

Addressed suggestions.

Copy link
Member

left a comment

The <p> tags are meant to be for paragraphs. You have paragraphs present but instead use the <p> tag as a content wrap and split paragraphs with <br/><br/>.

I'd suggest using the following structure:

          <p>
            We're a large community focused around the Python programming language.
            We believe anyone can learn to code, and are very dedicated to helping
            novice developers take their first steps into the world of programming. We also
            attract a lot of expert developers who are seeking friendships, collaborators,
            and who wish to hone their craft by teaching and getting involved in the community.
          </p>
          <p>
            We organise regular community events such as code jams, open-source hackathons,
            seasonal events, and community challenges. Through our sponsorships and donations,
            many of our events even have prizes to win!
          </p>
          <p>
            You can find help with most Python-related problems in one of our help channels.
            Our staff of over 50 dedicated expert Helpers are available around the clock
            in every timezone. Whether you're looking to learn the language or working on a
            complex project, we've got someone who can help you if you get stuck.
          </p>

As a side-note, XHTML requires the line break tag be closed (<b/>), but HTML5 does not.

Our doctype is <!DOCTYPE html> which is for HTML5, so the break tag shouldn't be closed: <br>. But with my suggestion above being to remove them entirely, it isn't entirely relevant.

lemonsaurus added 2 commits Oct 5, 2019
…cord/site into tizzysaurus_landing_page_text
@MarkKoz
MarkKoz approved these changes Oct 5, 2019
@lemonsaurus lemonsaurus dismissed scragly’s stale review Oct 11, 2019

It's been addressed, and Scragly is AWOL.

@lemonsaurus lemonsaurus merged commit eae341c into master Oct 11, 2019
2 checks passed
2 checks passed
Site Build #20191011.16 succeeded
Details
Site (Test & Lint) Test & Lint succeeded
Details
@lemonsaurus lemonsaurus deleted the tizzysaurus_landing_page_text branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.