Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations exclude in flake8 #275

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@MarkKoz
Copy link
Member

commented Oct 3, 2019

They were not being excluded when flake8 was invoked via pre-commit.

They were not being excluded when flake8 was invoked via pre-commit.
@sco1
sco1 approved these changes Oct 3, 2019
Copy link
Member

left a comment

The fix works as expected, but I'm not entirely sure if that tells us that it's working. The problem is that I can't replicate the difference in behavior, as precommit excludes the migration files with both versions of .flake8 in place on my machine. That makes me think that the behavior may be platform-dependent or dependent on "something" at least.

That said, if both versions work for some and the new version seems to work for everyone, the new version is definitely an improvement.

I've been able to replicate this now, but I don't see why it didn't previously. I did the same both times (trying to commit a change in a migration file that contained linting errors if not excluded) and this time it yelled at me without your fix.

@SebastiaanZ

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

I did some more testing and it consistently works with @MarkKoz's suggested change. I'll merge it now.

@SebastiaanZ SebastiaanZ merged commit 074aa91 into master Oct 4, 2019
2 checks passed
2 checks passed
Site Build #20191003.3 succeeded
Details
Site (Test & Lint) Test & Lint succeeded
Details
@SebastiaanZ SebastiaanZ deleted the flake8-exclude-fix branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.