From a29c403c77e4445e8abc966026f3153a24e2b6dd Mon Sep 17 00:00:00 2001
From: Johannes Christ <jc@jchri.st>
Date: Fri, 21 Apr 2023 21:07:20 +0200
Subject: [PATCH] Make unittests independent of GitHub

This fixes a problem where running the unit tests successively a lot
would result in 403 ratelimit exceeded errors being thrown due to the
GitHub API being called by the app.

Fixes #918
---
 .coveragerc                                 | 2 ++
 pydis_site/apps/content/tests/test_views.py | 5 +++--
 pydis_site/apps/home/tests/test_views.py    | 5 ++++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/.coveragerc b/.coveragerc
index 38926b22b..b41a21408 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -11,6 +11,8 @@ omit =
     */apps.py
     */urls.py
     pydis_site/apps/api/models/bot/metricity.py
+    # GitHub API functions are mocked away
+    pydis_site/apps/content/utils.py
     pydis_site/wsgi.py
     pydis_site/settings.py
     pydis_site/utils/resources.py
diff --git a/pydis_site/apps/content/tests/test_views.py b/pydis_site/apps/content/tests/test_views.py
index 3ef9bcc4d..e4f898ef0 100644
--- a/pydis_site/apps/content/tests/test_views.py
+++ b/pydis_site/apps/content/tests/test_views.py
@@ -1,6 +1,6 @@
 import textwrap
 from pathlib import Path
-from unittest import TestCase
+from unittest import TestCase, mock
 
 import django.test
 import markdown
@@ -223,7 +223,8 @@ def test_valid_tag_returns_200(self):
 
     def test_invalid_tag_404(self):
         """Test that a tag which doesn't exist raises a 404."""
-        response = self.client.get("/pages/tags/non-existent/")
+        with mock.patch("pydis_site.apps.content.utils.fetch_tags", autospec=True):
+            response = self.client.get("/pages/tags/non-existent/")
         self.assertEqual(404, response.status_code)
 
     def test_context_tag(self):
diff --git a/pydis_site/apps/home/tests/test_views.py b/pydis_site/apps/home/tests/test_views.py
index b1215df47..379b984ee 100644
--- a/pydis_site/apps/home/tests/test_views.py
+++ b/pydis_site/apps/home/tests/test_views.py
@@ -1,3 +1,5 @@
+from unittest import mock
+
 from django.test import TestCase
 from django.urls import reverse
 
@@ -6,5 +8,6 @@ class TestIndexReturns200(TestCase):
     def test_index_returns_200(self):
         """Check that the index page returns a HTTP 200 response."""
         url = reverse('home:home')
-        resp = self.client.get(url)
+        with mock.patch("pydis_site.apps.home.views.HomeView._get_api_data", autospec=True):
+            resp = self.client.get(url)
         self.assertEqual(resp.status_code, 200)