Bump To 3.11#153
Merged
Merged
Conversation
HassanAbouelela
added
area: dependencies
Contributor
Author
|
I might also go ahead and implement #149 since it's a relatively small change. I've already been using compose v2 and everything works as expected of course. |
MarkKoz
reviewed
Oct 31, 2022
Contributor
The dependencies only have lower bounds. I think they would only need to be updated if there is a package whose metadata indicates it works with 3.10 and higher, but in practice it doesn't actually support 3.11. |
Upgrade build image, configuration files, and documentation to python 3.11. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Run `make upgrade` to relock all dependency files with pip-tools on 3.11. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Remove the coveralls dependency in favor of the GitHub action uploader. The action is an official product from coveralls, and has the same features as the package, however it reduces the project's dependencies in favor of a simpler more stand-alone solution. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
3.11-upgrade
branch
from
8abe0aa to
531d0e2
Compare
Contributor
Author
|
I think you're right on the package dep front. |
Contributor
Author
|
Finished upgrading and testing runtime packages. All went fine. The following packages needed to build wheels:
We might want to upgrade them in the future, but overall very little building necessary |
HassanAbouelela
force-pushed
the
3.11-upgrade
branch
from
2f0e717 to
17d6dc9
Compare
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
3.11-upgrade
branch
from
17d6dc9 to
9aa2c3a
Compare
The compose file already uses compose v2 features, and most clients likely already alias docker-compose to v2 under the hood. This change is more of a formality. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
3.11-upgrade
branch
from
be2febd to
ce92e4d
Compare
Closed
One of the GitHub action files was failing validation due to an unindented block. It is unclear why this failure started now. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the snekbox version to the latest stable python version. Closes #152, closes #149
Possibly look into bumping dependency versions?I'll upgrade where possible to avoid the image having to compile a bunch of packages itself, to speed up builds, however we might have to revisit in the future as I imagine a lot of packages don't have wheels yet.