Skip to content

Import version number from a .py file rather than reading a .txt file. #5

Merged
merged 2 commits into from Apr 13, 2012

2 participants

@takluyver

The version.txt approach broke xlrd for people using freezer tools to bundle it into applications. This PR uses an info.py file to store the version number instead.

From discussion on the mailing list, although this needs a bit of a hack in setup.py, it should work for everyone.

@cjw296
python-excel member
cjw296 commented Apr 11, 2012

Have you tested this patch with the problematic freeze tools?
I'd rather not go round this particular circle again...

@takluyver

I'm pretty confident it should avoid the problem, but I'll test later today.

@cjw296
python-excel member
@takluyver

I replicated the problem in master using cx_Freeze, and confirmed that it works properly using this branch.

@takluyver

And it needed to be in MANIFEST as well, for sdists to include it. Just fixed that.

@cjw296 cjw296 merged commit 12f2fb3 into python-excel:master Apr 13, 2012
@takluyver
@cjw296
python-excel member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.