From 141f21a9982e3de54e8c8d6a5138cc08a91e1492 Mon Sep 17 00:00:00 2001 From: Gauvain Pocentek Date: Sat, 30 Jan 2016 17:45:34 +0100 Subject: [PATCH] Fix project update --- gitlab/cli.py | 4 ++-- gitlab/objects.py | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gitlab/cli.py b/gitlab/cli.py index 7fa176ce7..838bf076b 100644 --- a/gitlab/cli.py +++ b/gitlab/cli.py @@ -106,14 +106,14 @@ def _populate_sub_parser_by_class(cls, sub_parser): required=True) attrs = (cls.requiredUpdateAttrs - if cls.requiredUpdateAttrs is not None + if (cls.requiredUpdateAttrs or cls.optionalUpdateAttrs) else cls.requiredCreateAttrs) [sub_parser_action.add_argument("--%s" % x.replace('_', '-'), required=True) for x in attrs if x != cls.idAttr] attrs = (cls.optionalUpdateAttrs - if cls.optionalUpdateAttrs is not None + if (cls.requiredUpdateAttrs or cls.optionalUpdateAttrs) else cls.optionalCreateAttrs) [sub_parser_action.add_argument("--%s" % x.replace('_', '-'), required=False) diff --git a/gitlab/objects.py b/gitlab/objects.py index 28530a02a..ec66e17cb 100644 --- a/gitlab/objects.py +++ b/gitlab/objects.py @@ -728,9 +728,6 @@ class ProjectCommitStatus(GitlabObject): requiredUrlAttrs = ['project_id', 'commit_id'] requiredCreateAttrs = ['state'] optionalCreateAttrs = ['description', 'name', 'ref', 'target_url'] - requiredGetAttrs = [] - requiredUpdateAttrs = [] - requiredDeleteAttrs = [] class ProjectCommitStatusManager(BaseManager): @@ -1079,11 +1076,15 @@ class Project(GitlabObject): _url = '/projects' _constructorTypes = {'owner': 'User', 'namespace': 'Group'} requiredCreateAttrs = ['name'] - requiredUpdateAttrs = [] optionalCreateAttrs = ['default_branch', 'issues_enabled', 'wall_enabled', 'merge_requests_enabled', 'wiki_enabled', 'snippets_enabled', 'public', 'visibility_level', 'namespace_id', 'description', 'path', 'import_url'] + optionalUpdateAttrs = ['name', 'default_branch', 'issues_enabled', + 'wall_enabled', 'merge_requests_enabled', + 'wiki_enabled', 'snippets_enabled', 'public', + 'visibility_level', 'namespace_id', 'description', + 'path', 'import_url'] shortPrintAttr = 'path' managers = [ ('branches', ProjectBranchManager, [('project_id', 'id')]),