From 555cc45638f18bf74099fb8c8d6dca46a64fea73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mika=20M=C3=A4enp=C3=A4=C3=A4?= Date: Sat, 1 Nov 2014 14:59:00 +0200 Subject: [PATCH] Raise NotImplementedError on all cases, where can*-boolean is False --- gitlab.py | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/gitlab.py b/gitlab.py index c26986871..80345297e 100644 --- a/gitlab.py +++ b/gitlab.py @@ -552,20 +552,8 @@ def list(cls, gl, **kwargs): @classmethod def _getListOrObject(cls, gl, id, **kwargs): if id is None and cls.getListWhenNoId: - if not cls.canList: - raise GitlabListError return cls.list(gl, **kwargs) - elif id is None and not cls.getListWhenNoId: - if not cls.canGet: - raise GitlabGetError - return cls(gl, id, **kwargs) - elif isinstance(id, dict): - if not cls.canCreate: - raise GitlabCreateError - return cls(gl, id, **kwargs) else: - if not cls.canGet: - raise GitlabGetError return cls(gl, id, **kwargs) def _getObject(self, k, v): @@ -621,6 +609,8 @@ def __init__(self, gl, data=None, **kwargs): if data is None or isinstance(data, six.integer_types) or\ isinstance(data, six.string_types): + if not self.canGet: + raise NotImplementedError data = self.gitlab.get(self.__class__, data, **kwargs) # Object is created because we got it from api self._created = True