From a90eb23cb4903ba25d382c37ce1c0839642ba8fd Mon Sep 17 00:00:00 2001
From: "John L. Villalovos" <john@sodarock.com>
Date: Tue, 7 Dec 2021 23:05:08 -0800
Subject: [PATCH] chore: fix pylint error "expression-not-assigned"

Fix pylint error "expression-not-assigned" and remove check from the
disabled list.

And I personally think it is much more readable now and is less lines
of code.
---
 gitlab/v4/cli.py | 48 ++++++++++++++++++++----------------------------
 pyproject.toml   |  1 -
 2 files changed, 20 insertions(+), 29 deletions(-)

diff --git a/gitlab/v4/cli.py b/gitlab/v4/cli.py
index 1b981931f..675f93a32 100644
--- a/gitlab/v4/cli.py
+++ b/gitlab/v4/cli.py
@@ -266,20 +266,16 @@ def _populate_sub_parser_by_class(
                     sub_parser_action.add_argument(f"--{id_attr}", required=True)
 
             required, optional, dummy = cli.custom_actions[name][action_name]
-            [
-                sub_parser_action.add_argument(
-                    f"--{x.replace('_', '-')}", required=True
-                )
-                for x in required
-                if x != cls._id_attr
-            ]
-            [
-                sub_parser_action.add_argument(
-                    f"--{x.replace('_', '-')}", required=False
-                )
-                for x in optional
-                if x != cls._id_attr
-            ]
+            for x in required:
+                if x != cls._id_attr:
+                    sub_parser_action.add_argument(
+                        f"--{x.replace('_', '-')}", required=True
+                    )
+            for x in optional:
+                if x != cls._id_attr:
+                    sub_parser_action.add_argument(
+                        f"--{x.replace('_', '-')}", required=False
+                    )
 
     if mgr_cls.__name__ in cli.custom_actions:
         name = mgr_cls.__name__
@@ -293,20 +289,16 @@ def _populate_sub_parser_by_class(
                 sub_parser_action.add_argument("--sudo", required=False)
 
             required, optional, dummy = cli.custom_actions[name][action_name]
-            [
-                sub_parser_action.add_argument(
-                    f"--{x.replace('_', '-')}", required=True
-                )
-                for x in required
-                if x != cls._id_attr
-            ]
-            [
-                sub_parser_action.add_argument(
-                    f"--{x.replace('_', '-')}", required=False
-                )
-                for x in optional
-                if x != cls._id_attr
-            ]
+            for x in required:
+                if x != cls._id_attr:
+                    sub_parser_action.add_argument(
+                        f"--{x.replace('_', '-')}", required=True
+                    )
+            for x in optional:
+                if x != cls._id_attr:
+                    sub_parser_action.add_argument(
+                        f"--{x.replace('_', '-')}", required=False
+                    )
 
 
 def extend_parser(parser: argparse.ArgumentParser) -> argparse.ArgumentParser:
diff --git a/pyproject.toml b/pyproject.toml
index 6e83a2eed..2aa5b1d1e 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -55,7 +55,6 @@ disable = [
     "consider-using-sys-exit",
     "cyclic-import",
     "duplicate-code",
-    "expression-not-assigned",
     "fixme",
     "implicit-str-concat",
     "import-outside-toplevel",