Skip to content

Conversation

@Lukasa
Copy link
Member

@Lukasa Lukasa commented Mar 23, 2017

Resolves #371.

Basically, @dstufft is of the view that the sdist should contain baaaaasically everything that is in the repo, except for things that literally cannot be used (e.g. no need for a .gitignore because this isn't a git repo, or a travis.yml). This patch does that.

@dstufft
Copy link

dstufft commented Mar 23, 2017

You might be interested in adding a tox thing like:

[testenv:packaging]
deps =
    check-manifest
    readme_renderer
commands =
    check-manifest
    python setup.py check --metadata --restructuredtext --strict

That will check your README and make sure that all files that are commited to your VCS are either included or explicitly excluded from your sdist. In particular it makes it way harder to ship tarballs that are missing a file.

@Lukasa
Copy link
Member Author

Lukasa commented Mar 23, 2017

Sounds good to me. 👍

@Lukasa Lukasa force-pushed the package-more-stuff branch from df38960 to ab191e5 Compare March 23, 2017 13:39
@Lukasa
Copy link
Member Author

Lukasa commented Mar 23, 2017

Aaaaand done.

@dstufft
Copy link

dstufft commented Mar 23, 2017

Cool, I can't double approve but :shipit:

@Lukasa Lukasa merged commit cbc7665 into master Mar 23, 2017
@Lukasa Lukasa deleted the package-more-stuff branch March 23, 2017 14:14
@Lukasa
Copy link
Member Author

Lukasa commented Mar 23, 2017

Thanks @dstufft and @alexwlchan!

@dol-sen
Copy link

dol-sen commented Mar 23, 2017

Thank you :)

It'll make my pkg maintenance easier... and allow for those people that like to run the tests themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants