Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit amount of _closed_streams #1165

Merged
merged 6 commits into from Aug 5, 2018

Conversation

hellysmile
Copy link
Contributor

Fix for #1163

@hellysmile
Copy link
Contributor Author

docs travis build stacked, can You restart this build?

Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. If you can remove the unrelated change I’m happy to merge.

h2/connection.py Outdated
@@ -266,7 +266,7 @@ class H2Connection(object):
"""
# The initial maximum outbound frame size. This can be changed by receiving
# a settings frame.
DEFAULT_MAX_OUTBOUND_FRAME_SIZE = 65535
DEFAULT_MAX_OUTBOUND_FRAME_SIZE = 2**16 - 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unnecessary.

This reverts commit 2bf40ae.
@hellysmile
Copy link
Contributor Author

@Lukasa reverted, sorry for the change, wanted to make all params declared same way

Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks good to me, thanks!

@Lukasa Lukasa merged commit df2c842 into python-hyper:master Aug 5, 2018
@hellysmile hellysmile deleted the limit_closed_streams branch August 5, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants