-
Notifications
You must be signed in to change notification settings - Fork 41
adding initial MANIFEST.in #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
======================================
Coverage 97.6% 97.6%
======================================
Files 6 6
Lines 1044 1044
Branches 120 120
======================================
Hits 1019 1019
Misses 13 13
Partials 12 12Continue to review full report at Codecov.
|
|
python-hyper “standard”, insofar as there is one, is to include everything from the repo in the sdist that might be useful – see python-hyper/h2#501 (On a phone, so can’t double-check the proposed MANIFEST.in against the repo contents right now.) |
|
Yeah, so my strong recommendation would be to add the testing from python-hyper/h2#501 to validate that the Manifest just basically contains the entire git repo. This seems to be what's most popular with downstream repackagers. However, if you don't want to do that, that's fine. Just let me know and I'll review with that in mind. |
…t everything is included
|
Alright, python-hyper/h2#501 is fully implemented. Added more files, plus the |
|
Don’t forget to add the new test to CI. |
|
Yup, per @alexwlchan's note we should add the new test env to the CI. 😁 |
Lukasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, assuming we get a green test run we can go ahead and merge this.
alexwlchan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Adding a MANIFEST.in to include a few files (LICENSE, README, docs). Not sure if there's a python-hyper standard approach to this, so feedback is welcome!