New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests pass after 2028 #277
Conversation
Extend the lifetime of test certs to not expire so soon. Background: As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future. The usual offset is +15 years, because that is how long I expect some software will be used in some places. This showed up failing tests in our package build. See https://reproducible-builds.org/ for why this matters.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
======================================
Coverage 71.1% 71.1%
======================================
Files 49 49
Lines 4818 4818
Branches 812 812
======================================
Hits 3426 3426
- Misses 1056 1057 +1
+ Partials 336 335 -1
Continue to review full report at Codecov.
|
|
Thanks for the pull request. I like the idea to extend the certs. However 2994 seems a bit excessive. For now I'd prefer to keep dates before 2038 to avoid Epochalypse bugs. How about a validity of 15 years, then? |
|
If there were y2038 bugs, it would be better to detect and fix them now rather than in 15y. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me – what should expose bugs if not tests?
|
any concerns that prevent merging? |
|
ping. I'd still like to see this merged |
Extend the lifetime of test certs to not expire so soon.
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.
I tested, that with the patch, everything passed in 2034.