Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass after 2028 #277

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bmwiedemann
Copy link

commented Apr 12, 2019

Extend the lifetime of test certs to not expire so soon.

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

I tested, that with the patch, everything passed in 2034.

Make tests pass after 2028
Extend the lifetime of test certs to not expire so soon.

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.
@codecov

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #277   +/-   ##
======================================
  Coverage    71.1%   71.1%           
======================================
  Files          49      49           
  Lines        4818    4818           
  Branches      812     812           
======================================
  Hits         3426    3426           
- Misses       1056    1057    +1     
+ Partials      336     335    -1
Impacted Files Coverage Δ
Lib/ldap/controls/deref.py 57.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9dc4...b22cb68. Read the comment docs.

@tiran

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Thanks for the pull request. I like the idea to extend the certs. However 2994 seems a bit excessive. For now I'd prefer to keep dates before 2038 to avoid Epochalypse bugs. How about a validity of 15 years, then?

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Apr 13, 2019

If there were y2038 bugs, it would be better to detect and fix them now rather than in 15y.
At least these certs do not trigger any test failures on i586 or x86_64 neither today nor in 2037.
So should be fine.

@encukou
Copy link
Member

left a comment

This looks reasonable to me – what should expose bugs if not tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.