Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Jedi upper pin to <0.20 #416

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Bump Jedi upper pin to <0.20 #416

merged 1 commit into from
Aug 12, 2023

Conversation

bnavigator
Copy link
Contributor

There doesn't seem to be any breaking change in jedi 0.19

Closes #414

@ccordoba12 ccordoba12 added this to the v1.8.0 milestone Aug 12, 2023
ccordoba12
ccordoba12 approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnavigator for your help with this!

pyproject.toml Show resolved Hide resolved
@ccordoba12 ccordoba12 merged commit f33a93a into python-lsp:develop Aug 12, 2023
10 checks passed
@AdamWill AdamWill mentioned this pull request Aug 29, 2023
Closed
7 tasks
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Sep 6, 2023
@WhyNotHugo
community/py3-lsp-server: bump pinned dependency version
e962d8f 
Without this, all modules fail to load at runtime:

    2023-09-05 17:55:30,637 CEST - INFO - pylsp.python_lsp - Serving PythonLSPServer on (127.0.0.1, 9977)
    2023-09-05 17:55:34,279 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'pylsp_mypy': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'), {'python-lsp-server'})
    2023-09-05 17:55:34,282 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'pylsp_black': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'), {'python-lsp-server'})
    2023-09-05 17:55:34,282 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'autopep8': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'flake8': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'folding': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_completion': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_definition': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_highlight': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_hover': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,283 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_references': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_rename': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_signature_help': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'jedi_symbols': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'mccabe': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'preload': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'pycodestyle': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'pydocstyle': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,284 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'pyflakes': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,285 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'pylint': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,285 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'rope_autoimport': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,285 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'rope_completion': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,285 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'rope_rename': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,285 CEST - INFO - pylsp.config.config - Failed to load pylsp entry point 'yapf': (jedi 0.19.0 (/usr/lib/python3.11/site-packages), Requirement.parse('jedi<0.19.0,>=0.17.2'))
    2023-09-05 17:55:34,290 CEST - INFO - pylsp.config.config - Disabled plugins: []

The jedi bump has no breaking changes, as mentioned upstream.

See: python-lsp/python-lsp-server#416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Support Jedi 0.19
2 participants
@bnavigator @ccordoba12