Preparing for refactor of Settings. #125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Managing different types of Settings may be achieved more flexibly and simply through the use of subclasses of Setting and the use of a factory pattern or helper method for their creation. * Added TODO * Replaced direct instantiation of Settings with creation through method.
carandraug
pushed a commit
that referenced
this pull request
Dec 17, 2019
#125) Managing different types of Settings may be achieved more flexibly and simply through the use of subclasses of Setting and the use of a factory pattern or helper method for their creation. So make the `Setting` class and the `Device.settings` attribute private so that the `Device` methods become the only sactioned method to get to them. * microscope/cameras/atmcd.py: use the `*_setting` methods instead of manipulating `self.settings` directly. * microscope/devices.py: mark `Setting` class and `Device.settings` attribute as private. * microscope/testsuite/test_setting.py: Setting class is now _Setting. * NEWS: make note of backwards incompatible change.
Collaborator
|
Pushed after also making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managing different types of Settings may be achieved more flexibly and simply through the use of subclasses of Setting and the use of a factory pattern or helper method for their creation.