Skip to content

Conversation

@p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Jun 4, 2021

Unsupported deserializers raise warning.

  • media type deserializers raise MediaTypeDeserializeError (which inherits from DeserializeError ) instead of DeserializeError itself
  • parameter deserializers raise ParameterDeserializeError (which inherits from DeserializeError ) instead of DeserializeError itself

Backward compatibilities:

  • EmptyParameterValue exception renamed to EmptyQueryParameterValue

@p1c2u p1c2u force-pushed the refactor/deserializing-refactor branch 2 times, most recently from a938861 to 5620beb Compare June 4, 2021 11:22
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #347 (5620beb) into master (f3d7d73) will decrease coverage by 0.25%.
The diff coverage is 87.50%.

❗ Current head 5620beb differs from pull request most recent head a7125ca. Consider uploading reports for the commit a7125ca to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   95.88%   95.62%   -0.26%     
==========================================
  Files          79       81       +2     
  Lines        1651     1692      +41     
==========================================
+ Hits         1583     1618      +35     
- Misses         68       74       +6     
Impacted Files Coverage Δ
openapi_core/deserializing/exceptions.py 100.00% <ø> (+12.50%) ⬆️
...api_core/deserializing/parameters/deserializers.py 91.17% <81.25%> (-8.83%) ⬇️
...penapi_core/deserializing/parameters/exceptions.py 89.47% <85.71%> (+3.75%) ⬆️
openapi_core/deserializing/parameters/factories.py 91.66% <85.71%> (-8.34%) ⬇️
...enapi_core/deserializing/media_types/exceptions.py 87.50% <87.50%> (ø)
...pi_core/deserializing/media_types/deserializers.py 95.00% <92.30%> (-5.00%) ⬇️
...penapi_core/deserializing/media_types/factories.py 100.00% <100.00%> (ø)
openapi_core/deserializing/parameters/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d7d73...a7125ca. Read the comment docs.

@p1c2u p1c2u force-pushed the refactor/deserializing-refactor branch from 5620beb to a7125ca Compare June 4, 2021 11:30
@p1c2u p1c2u merged commit b4cff7b into master Jun 4, 2021
@p1c2u p1c2u deleted the refactor/deserializing-refactor branch June 4, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants