Improve Pendulum.now and Pendulum.utcnow performance #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my discussion in #171 (comment) and the same reasoning as arrow-py/arrow#486 (comment), I think that
pendulumshould take advantage of the fact thatdatetime.now()takes atzinfoobject as an argument to provide aware datetimes.In Python 3.6 on my Arch Linux laptop. With this patch:
Before this patch:
I guess it doesn't have a major effect on the speed of
utcnow()for whatever reason, but it at the very least doesn't have a negative performance impact, and it's also the right thing to do when constructing aware datetimes.