Fix typing of Timezone and ZoneInfo #670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the method used to import
zoneinfoleaves it typed asAnyinmypyandUnknowninpyright. This PR updatespendulum.utils._compatto inform type checkers of the correct type information forzoneinfowhile leaving the import mechanism the same during runtime. WithTimezonehaving the correct type info fromZoneInfo, a few more type errors surfaced which I took care of either by adding/removing# type: ignoreor adding/removingcast()calls. Since no logic has changed at runtime, no unit tests were added.