Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Pillow-SIMD in Pillow #2148

Closed
aclark4life opened this issue Oct 3, 2016 · 7 comments
Closed

Include Pillow-SIMD in Pillow #2148

aclark4life opened this issue Oct 3, 2016 · 7 comments
Milestone

Comments

@aclark4life
Copy link
Member

@homm Just noticed https://pypi.python.org/pypi/Pillow-SIMD/3.3.2.post0 and wanted to explore the reasons why we don't include this in Pillow here.

@homm
Copy link
Member

homm commented Oct 3, 2016

The reasons described here: https://github.com/uploadcare/pillow-simd#why-do-not-contribute-simd-to-the-original-pillow
and here: uploadcare#8

In short: we can't include this as is because it will break a lot of users. And there is no easy way to turn on this only for some users.

@aclark4life
Copy link
Member Author

@homm I understand that part. I'm just saying, you could probably move the project here but continue to do separate package releases, if you are interested in doing so. Otherwise, no worries.

@homm
Copy link
Member

homm commented Oct 3, 2016

By "moving here" you are referring to the transfer "pillow-simd" repo to the "python-pillow" organization?

@aclark4life
Copy link
Member Author

Right, assuming you require a separate repo. Ideally you could just do SIMD stuff in a branch, or something. But yeah you are welcome to move the repo here if you like.

@homm
Copy link
Member

homm commented Oct 3, 2016

Ok, thanks for the proposition. At the moment I want to have for Pillow-SIMD at least separate readme (which will not be so elegant in a branch) and issues (less important).

There is a small announcement: I currently work on SIMD 3.4.0 release as well as Pillow-perf tools and page: http://homm.github.io/pillow-perf/ (just a beginning)

Maybe when I'm done, we could move current SIMD readme to a documentation page.

@aclark4life aclark4life added this to the Future milestone Jan 8, 2017
@aclark4life
Copy link
Member Author

@homm Did this happen? I see https://github.com/python-pillow/pillow-perf

@hugovk
Copy link
Member

hugovk commented Feb 17, 2019

I'll close this issue.

I see https://github.com/python-pillow/pillow-perf is now in this org.

Just ping and re-open if you'd like to transfer https://github.com/uploadcare/pillow-simd over. 👍

@hugovk hugovk closed this as completed Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants