Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TIFF G4 images are not well decoded #279

Closed
jfbecan opened this issue Jul 9, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@jfbecan
Copy link

commented Jul 9, 2013

TIFF G4 with a FillOrder Tag (266) indicating a value of 2 (pixels are arranged within a byte such that pixels with lower column values are stored in the lower-order bits of the byte.) are not well decoded even if it seems that code to treat them is available.
Unfortunately I can't join such Tiff files because only PNG, GIF or JPG are accepted.

@wiredfool

This comment has been minimized.

Copy link
Member

commented Jul 9, 2013

I'd like to see the image that fails. Can you either email it to me, put it in a new repo on github, or put it on dropbox?

@jfbecan

This comment has been minimized.

Copy link
Author

commented Jul 9, 2013

I attached 2 Tiff G4 files that have a FillOrder equal to 2.

----- Mail original -----

| I'd like to see the image that fails. Can you either email it to me,
| put it in a new repo on github, or put it on dropbox?
| —
| Reply to this email directly or view it on GitHub .

@wiredfool

This comment has been minimized.

Copy link
Member

commented Jul 9, 2013

Looks like those got stripped by github, can you email me direct @ eric-github@soroos.net .

@wiredfool

This comment has been minimized.

Copy link
Member

commented Jul 9, 2013

Ok, that's a reproduced bug here.
garbled
not_garbled

I'll dig on it.

@ghost ghost assigned wiredfool Jul 9, 2013

wiredfool added a commit to wiredfool/Pillow that referenced this issue Jul 11, 2013

@wiredfool

This comment has been minimized.

Copy link
Member

commented Jul 11, 2013

Ok, looks like libtiff was doing the fillorder correction for us, and then the shuffle function was doing it again. I've patched around it. PR #284

@wiredfool wiredfool referenced this issue Jul 11, 2013

Merged

G4 fillorder #284

@jfbecan

This comment has been minimized.

Copy link
Author

commented Jul 11, 2013

I just test your patch : it works.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.