Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub service hook for RTD broken #769

Closed
aclark4life opened this issue Jul 4, 2014 · 23 comments

Comments

Projects
None yet
3 participants
@aclark4life
Copy link
Member

commented Jul 4, 2014

I have no idea why, but the GitHub service hook for Readthedocs seems to be broken i.e. when I push to the Pillow repo the docs do not build; I have to manually trigger.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2014

CC: @irskep

@irskep

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2014

I'll investigate this weekend, maybe today.

On Jul 4, 2014, at 12:07 PM, Alex Clark ☺ notifications@github.com wrote:

CC: @irskep


Reply to this email directly or view it on GitHub.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2014

Thank you @irskep!

@irskep

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2014

It looks like I can't debug this, since I'd have to be a project admin. The best I can do is recommend you double check the repo settings against this: http://read-the-docs.readthedocs.org/en/latest/webhooks.html

@irskep

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2014

BTW, props to you and the community for keeping the docs up to date. My motivation to do big conversions like the Pillow docs comes in spurts, so it's been nice to have other people handle day-to-day maintenance after the initial dump was done. Please keep pinging me when general docs issues arise.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2014

Will do! Thanks for the initial dump, it's working really well for us. OK I clicked update service, maybe that will help. There's not a whole lot to the configuration so it seems like it should "just work".
screenshot 2014-07-04 17 13 57

@hugovk

This comment has been minimized.

Copy link
Member

commented Sep 22, 2014

I clicked to manually build the latest version but it failed:

https://readthedocs.org/builds/pillow/1700210/

@hugovk

This comment has been minimized.

Copy link
Member

commented Sep 30, 2014

http://pillow.readthedocs.org/ is broken ("You've found something that doesn't exist."), I suspect as the RTD builds are failing. I'm not familiar with RTD but it looks like Sphinx is being called with bad parameters.

Interestingly, PDF builds are working but not HTML builds.

From an old passing HTML build, stdout of the html section is:

Running Sphinx v1.1.3
loading translations [en]... locale not available
loading intersphinx inventory from http://docs.python.org/2/objects.inv...
building [readthedocs]: targets for 34 source files that are out of date
updating environment: 34 added, 0 changed, 0 removed
reading sources... [  2%] PIL
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pillow/envs/latest/local/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 321, in import_object
    __import__(self.modname)
  File "build/bdist.linux-x86_64/egg/PIL/ImageCms.py", line 93, in <module>
ImportError: cannot import name import_err
reading sources... [  5%] about
reading sources... [  8%] developer
reading sources... [ 11%] guides
reading sources... [ 14%] handbook/appendices
reading sources... [ 17%] handbook/concepts
reading sources... [ 20%] handbook/image-file-formats
reading sources... [ 23%] handbook/overview
reading sources... [ 26%] handbook/tutorial
reading sources... [ 29%] handbook/writing-your-own-file-decoder
reading sources... [ 32%] index
reading sources... [ 35%] installation
reading sources... [ 38%] original-readme
reading sources... [ 41%] porting-pil-to-pillow
reading sources... [ 44%] reference/Image
reading sources... [ 47%] reference/ImageChops
reading sources... [ 50%] reference/ImageColor
reading sources... [ 52%] reference/ImageDraw
reading sources... [ 55%] reference/ImageEnhance
reading sources... [ 58%] reference/ImageFile
reading sources... [ 61%] reference/ImageFilter
reading sources... [ 64%] reference/ImageFont
reading sources... [ 67%] reference/ImageGrab
reading sources... [ 70%] reference/ImageMath
reading sources... [ 73%] reference/ImageOps
reading sources... [ 76%] reference/ImagePalette
reading sources... [ 79%] reference/ImagePath
reading sources... [ 82%] reference/ImageQt
reading sources... [ 85%] reference/ImageSequence
reading sources... [ 88%] reference/ImageStat
reading sources... [ 91%] reference/ImageTk
reading sources... [ 94%] reference/ImageWin
reading sources... [ 97%] reference/PSDraw
reading sources... [100%] reference/index

looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [  2%] PIL
writing output... [  5%] about
writing output... [  8%] developer
writing output... [ 11%] guides
writing output... [ 14%] handbook/appendices
writing output... [ 17%] handbook/concepts
writing output... [ 20%] handbook/image-file-formats
writing output... [ 23%] handbook/overview
writing output... [ 26%] handbook/tutorial
writing output... [ 29%] handbook/writing-your-own-file-decoder
writing output... [ 32%] index
writing output... [ 35%] installation
writing output... [ 38%] original-readme
writing output... [ 41%] porting-pil-to-pillow
writing output... [ 44%] reference/Image
writing output... [ 47%] reference/ImageChops
writing output... [ 50%] reference/ImageColor
writing output... [ 52%] reference/ImageDraw
writing output... [ 55%] reference/ImageEnhance
writing output... [ 58%] reference/ImageFile
writing output... [ 61%] reference/ImageFilter
writing output... [ 64%] reference/ImageFont
writing output... [ 67%] reference/ImageGrab
writing output... [ 70%] reference/ImageMath
writing output... [ 73%] reference/ImageOps
writing output... [ 76%] reference/ImagePalette
writing output... [ 79%] reference/ImagePath
writing output... [ 82%] reference/ImageQt
writing output... [ 85%] reference/ImageSequence
writing output... [ 88%] reference/ImageStat
writing output... [ 91%] reference/ImageTk
writing output... [ 94%] reference/ImageWin
writing output... [ 97%] reference/PSDraw
writing output... [100%] reference/index

writing additional files... (35 module code pages) _modules/index
 genindex py-modindex search
copying static files... done
dumping search index... done
dumping object inventory... done
build succeeded, 17 warnings.
Copying readthedocs-ext.js_t... done

But instead a failing HTML build has this stderr for the html section:

Sphinx v1.1.3
Usage: /home/docs/checkouts/readthedocs.org/user_builds/pillow/envs/latest/bin/sphinx-build [options] sourcedir outdir [filenames...]
Options: -b <builder> -- builder to use; default is html
         -a        -- write all files; default is to only write new and changed files
         -E        -- don't use a saved environment, always read all files
         -t <tag>  -- include "only" blocks with <tag>
         -d <path> -- path for the cached environment and doctree files
                      (default: outdir/.doctrees)
         -c <path> -- path where configuration file (conf.py) is located
                      (default: same as sourcedir)
         -C        -- use no config file at all, only -D options
         -D <setting=value> -- override a setting in configuration
         -A <name=value>    -- pass a value into the templates, for HTML builder
         -n        -- nit-picky mode, warn about all missing references
         -N        -- do not do colored output
         -q        -- no output on stdout, just warnings on stderr
         -Q        -- no output at all, not even warnings
         -w <file> -- write warnings (and errors) to given file
         -W        -- turn warnings into errors
         -P        -- run Pdb on exception
Modi:
* without -a and without filenames, write new and changed files.
* with -a, write all files.
* with filenames, write these.

What's the difference between master and latest? Both are failing, but at least there's something (old?) at http://pillow.readthedocs.org/en/latest/.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2014

Yep, working on it.

@irskep

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2014

Let me know if you'd like assistance.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2014

@irskep Always, thanks 😄 I've just been fiddling…

@irskep

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2014

Might not have time today, unfortunately. Will try again tomorrow.

@irskep

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

The docs build locally. Not sure what's up with RtD.

@irskep

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Maybe try upgrading Sphinx to 1.2.3?

@irskep

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

The build started failing "1 week, 1 day" ago.

@irskep

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

This is the first build that failed. The next most recent build was almost 3 months prior.

d328b48

@irskep

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

That's all the investigation I have time for right now.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2014

@irskep Thanks for looking!

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2014

No idea what happened, but I removed and recreated Pillow on RTD and disabled the "better" theme and now it works.

@aclark4life aclark4life closed this Oct 1, 2014

@hugovk

This comment has been minimized.

Copy link
Member

commented Oct 1, 2014

The good old turning-it-off-and-on-again!

@irskep

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Aw, it was probably the theme. Sounds like I have some work to do on that (I made the theme).

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2014

@hugovk And to answer your question re: master vs. latest, no important difference; these are RTD configuration options. And I've also just checked the Single Version option to simplify things further.
screenshot 2014-10-01 15 35 59
option for now.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2014

@irksep Not sure. The only error I got was on import, so I don't immediately suspect the theme; I just removed it to simplify. I've added you and @hugovk to the Maintainers list again in case you want to fiddle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.