Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aclark contributing nits #1181

Merged
merged 2 commits into from Apr 5, 2015

Conversation

Projects
None yet
2 participants
@aclark4life
Copy link
Member

commented Apr 5, 2015

Why do we ask folks to create a branch within their fork?

aclark4life added a commit that referenced this pull request Apr 5, 2015

@aclark4life aclark4life merged commit f0d84d8 into master Apr 5, 2015

@aclark4life aclark4life deleted the aclark-contributing-nits branch Apr 5, 2015

@wiredfool

This comment has been minimized.

Copy link
Member

commented Apr 5, 2015

Because it's easier to be sure that there are no accidential commits between reviewing and committing, especially for PRs that don't get reviewed quickly.

@aclark4life

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2015

Cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.