New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the olefile dependency to be optional #2789

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
3 participants
@jdufresne
Contributor

jdufresne commented Oct 4, 2017

Support for plugins requiring olefile will not be loaded if it is not installed. Allows library consumers to avoid installing this dependency if they choose. Some library consumers have little interest in the format support and would like to keep dependencies to a minimum.

Changes proposed in this pull request:

  • olefile support is no longer a required dependency
  • if it is exists, image support requiring olefile continues to be available
Allow the olefile dependency to be optional
Support for plugins requiring olefile will not be loaded if it is not
installed. Allows library consumers to avoid installing this dependency
if they choose. Some library consumers have little interest in the
format support and would like to keep dependencies to a minimum.

@hugovk hugovk added the olefile label Oct 4, 2017

@wiredfool

This comment has been minimized.

Show comment
Hide comment
@wiredfool

wiredfool Nov 5, 2017

Member

This needs release notes and potentially additional documentation.

Release note ping: #2832

Member

wiredfool commented Nov 5, 2017

This needs release notes and potentially additional documentation.

Release note ping: #2832

@wiredfool wiredfool merged commit 533c5df into python-pillow:master Nov 5, 2017

5 checks passed

codecov/patch Coverage not affected when comparing 8a4a1e0...9175706
Details
codecov/project 83.36% remains the same compared to 8a4a1e0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 83.364%
Details

@hugovk hugovk referenced this pull request Nov 6, 2017

Merged

Add release notes for 4.4.0 #2836

@jdufresne jdufresne deleted the jdufresne:olefile-optional branch Jan 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment