New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count of BITSPERSAMPLE items in broken TIFF files #2883

Merged
merged 3 commits into from Dec 9, 2017

Conversation

Projects
None yet
2 participants
@homm
Member

homm commented Dec 7, 2017

I met TIFF file with following format key:

format key: ('II', 2, (1,), 1, (8,), (2,))

This is the wrong format because of specs says:

Most RGB files will have the same number of BitsPerSample for each component. Even in this case, the writer must write all three values.

But those files are still opened by most viewers.

@homm homm added the Needs Tests label Dec 7, 2017

homm added some commits Dec 8, 2017

@homm homm removed the Needs Tests label Dec 8, 2017

@wiredfool

This comment has been minimized.

Show comment
Hide comment
@wiredfool

wiredfool Dec 9, 2017

Member

We've definitely got some cases where we've manually added signatures for the various BPP values. Normalizing this makes sense.

Member

wiredfool commented Dec 9, 2017

We've definitely got some cases where we've manually added signatures for the various BPP values. Normalizing this makes sense.

@wiredfool wiredfool merged commit 9ed4ea9 into python-pillow:master Dec 9, 2017

5 checks passed

codecov/patch 100% of diff hit (target 83.38%)
Details
codecov/project 83.38% (+<.01%) compared to 6eb534b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 83.389%
Details

@homm homm deleted the uploadcare:tiff-wrong-bitspersample branch Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment