Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings if imaging library has wrong UCS support. #298

Merged
merged 1 commit into from Jul 23, 2013

Conversation

Projects
None yet
3 participants
@macfreek
Copy link
Contributor

commented Jul 23, 2013

Fix for #297.

Please note that this fix raises the original exception when an unknown error occurs. An alternative is to also call warnings.warn(str(v)) for unknown errors.

Warnings if imaging library has wrong UCS support.
Raise exceptions for unknown errors.
@macfreek

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2013

Please carefully review the pull request. I'm not familiar with the intrinsics of Pillow (heck, the fact that I used a different Python (--without-wide-unicode) to build & install Pillow than the one to run Pillow (---with-wide-unicode) is already a give-away that I'm perfectly able to screw things up ;)

@aclark4life

This comment has been minimized.

Copy link
Member

commented Jul 23, 2013

@macfreek Thanks! We'll take a look

@wiredfool

This comment has been minimized.

Copy link
Member

commented Jul 23, 2013

I think we can go farther... I'll have an updated pull request.

@aclark4life

This comment has been minimized.

Copy link
Member

commented Jul 23, 2013

Thanks @wiredfool

@aclark4life aclark4life merged commit d24a419 into python-pillow:master Jul 23, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.