Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGA: Read and write LA data #3178

Merged
merged 1 commit into from Jul 1, 2018

Conversation

Projects
None yet
2 participants
@danpla
Copy link
Contributor

commented Jun 12, 2018

No description provided.


# There are 559 transparent pixels.
im = im.convert('RGBA')
self.assertEqual(im.getchannel('A').getcolors()[0][0], 559)

This comment has been minimized.

Copy link
@hugovk

hugovk Jun 14, 2018

Member
  • This test opens l_trns.tga and saves it to a temp file.
  • It then converts the image to RGBA and asserts the number of pixels.

It's good it's making sure the save runs without exception, but it doesn't verify the save.

How about opening the saved file and asserting something there? Have a look at the other tests here.

TGA
^^^

PIL reads 24- and 32-bit uncompressed and run-length encoded TGA files.

This comment has been minimized.

Copy link
@hugovk

hugovk Jun 14, 2018

Member

Do we not need to mention the 24- and 32-bit any more?

@@ -558,6 +558,13 @@ For more information about the SPIDER image processing package, see the
.. _SPIDER homepage: https://spider.wadsworth.org/spider_doc/spider/docs/spider.html
.. _Wadsworth Center: https://www.wadsworth.org/

TGA

This comment has been minimized.

Copy link
@hugovk

hugovk Jun 14, 2018

Member

Thanks for re-ordering these!

@hugovk hugovk merged commit 80d399a into python-pillow:master Jul 1, 2018

4 checks passed

codecov/patch 100% of diff hit (target 83.48%)
Details
codecov/project 83.49% (+<.01%) compared to 3b7e563
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.