Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double free in font loading failure #3854

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@nijel
Copy link
Contributor

commented May 15, 2019

The memory is freeed in font_dealloc, doing that again leads to SIGABRT.

Fixes #3853.

Changes proposed in this pull request:

  • it removes double free in error handling path

I wanted to add test for this, but the error handling futher is broken as well (the invalid font raises IOError, which is later intepreted as missing file and loader tries to do os.path.basename on a file like object), so I ended up fixing the crash only for now.

Fix double free in font loading failure
The memory is freeed in font_dealloc, doing that again leads to SIGABRT.

@radarhere radarhere added the Fonts label May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.