Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to capture all monitors on Windows #3950

Merged
merged 4 commits into from Sep 27, 2019

Conversation

@nulano
Copy link
Contributor

nulano commented Jul 5, 2019

Resolves #1547

Provides workaround for #2438, #3432, #3626:
For some reason grabbing a screenshot of the whole screen with the new ImageGrab.grab(multimonitor=True) ignores DPI scaling properly.

Edit: I didn't look at the screenshot closely enough.

@radarhere radarhere changed the title add option to capture all monitors on Windows Add option to capture all monitors on Windows Jul 5, 2019
src/PIL/ImageGrab.py Outdated Show resolved Hide resolved
src/display.c Outdated Show resolved Hide resolved
@hugovk hugovk mentioned this pull request Jul 15, 2019
@nulano nulano force-pushed the nulano:imagegrab_multimonitor branch from 4ffa0e4 to 92b7bd6 Jul 31, 2019
@nulano

This comment has been minimized.

Copy link
Contributor Author

nulano commented Jul 31, 2019

I have removed the FIXME comment now that it will be resolved by #4000 (it was in the wrong place anyway).

@radarhere radarhere force-pushed the nulano:imagegrab_multimonitor branch from 92b7bd6 to fa6b80f Aug 15, 2019
@aclark4life aclark4life added this to New Issues in Pillow Sep 12, 2019
src/PIL/ImageGrab.py Outdated Show resolved Hide resolved
@hugovk hugovk merged commit 310d2c9 into python-pillow:master Sep 27, 2019
14 checks passed
14 checks passed
python-pillow.Pillow Build #20190926.8 succeeded
Details
python-pillow.Pillow (Lint Python37) Lint Python37 succeeded
Details
python-pillow.Pillow (alpine) alpine succeeded
Details
python-pillow.Pillow (amazon_1_amd64) amazon_1_amd64 succeeded
Details
python-pillow.Pillow (amazon_2_amd64) amazon_2_amd64 succeeded
Details
python-pillow.Pillow (arch) arch succeeded
Details
python-pillow.Pillow (centos_6_amd64) centos_6_amd64 succeeded
Details
python-pillow.Pillow (centos_7_amd64) centos_7_amd64 succeeded
Details
python-pillow.Pillow (debian_10_buster_x86) debian_10_buster_x86 succeeded
Details
python-pillow.Pillow (debian_9_stretch_x86) debian_9_stretch_x86 succeeded
Details
python-pillow.Pillow (fedora_29_amd64) fedora_29_amd64 succeeded
Details
python-pillow.Pillow (fedora_30_amd64) fedora_30_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_16_04_xenial_amd64) ubuntu_16_04_xenial_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_18_04_bionic_amd64) ubuntu_18_04_bionic_amd64 succeeded
Details
@hugovk

This comment has been minimized.

Copy link
Member

hugovk commented Sep 27, 2019

Thanks!

radarhere added a commit to radarhere/Pillow that referenced this pull request Sep 28, 2019
radarhere added a commit to radarhere/Pillow that referenced this pull request Sep 28, 2019
@nulano nulano deleted the nulano:imagegrab_multimonitor branch Sep 28, 2019
radarhere added a commit that referenced this pull request Sep 29, 2019
Documented #3950 in the release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pillow
  
New Issues
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.