Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow floodfill to extend into negative coordinates #4017

Open
wants to merge 1 commit into
base: master
from

Conversation

@radarhere
Copy link
Member

commented Aug 9, 2019

Resolves #4016

At the moment, ImageDraw.floodfill doesn't stop filling new pixels just because their coordinates happen to be negative - when filling the next pixels around (0, 0), it also uses (-1, -1). So it continues, and wraps around to the other side of the image.

To demonstrate, with this image -

base

filling a coordinate in the upper left of this image before this fix gives -

out

This PR fixes it -

imagedraw_floodfill_not_negative

@radarhere radarhere added the Bug label Aug 9, 2019

@radarhere radarhere force-pushed the radarhere:floodfill branch from bda4941 to 23872c0 Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.