Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more deprecated bdist_wininst .exe installers #4029

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@hugovk
Copy link
Member

hugovk commented Aug 18, 2019

bdist_wininst (.exe installers) has been deprecated in Python 3.8, and bdist_wheel (wheel packages) should be used instead:

As far as I can see in the codebase, it's only used in build.py --dist to create Windows installers for testing dev builds. There's already a build.py --wheel option for bdist_wheel packages. So let's remove --dist.


In https://discuss.python.org/t/deprecate-bdist-wininst/1929/12?u=hugovk, @cgohlke pointed out:

PyPI doesn’t even allow you to upload bdist_wininst (See PEP 527 ) anymore

Maybe a bug: Pillow still uploads bdist_wininst installers for Windows.

@cgohlke Are those .exe installers something you normally send over each release day? If so, we can just skip those.


Any objections to stop distributing .exe installers for the next release?

Here's the output of pypinfo --limit 10 pillow file, showing the download count for the Pillow files on PyPI over the last 30 days:

Served from cache: True
Data processed: 0.00 B
Data billed: 0.00 B
Estimated cost: $0.00

file download_count
Pillow-6.1.0-cp27-cp27mu-manylinux1_x86_64.whl 1,747,882
Pillow-6.1.0-cp36-cp36m-manylinux1_x86_64.whl 961,926
Pillow-6.1.0-cp35-cp35m-manylinux1_x86_64.whl 531,485
Pillow-6.1.0-cp37-cp37m-manylinux1_x86_64.whl 438,457
Pillow-6.1.0-cp37-cp37m-win_amd64.whl 146,346
Pillow-6.1.0.tar.gz 133,063
Pillow-6.0.0-cp36-cp36m-manylinux1_x86_64.whl 131,780
Pillow-5.4.1-cp36-cp36m-manylinux1_x86_64.whl 123,360
Pillow-6.1.0-cp37-cp37m-win32.whl 113,811
Pillow-5.3.0-cp27-cp27mu-manylinux1_x86_64.whl 104,872
Total 4,432,982

And pypinfo --limit 1000 pillow file, contains no .exe and the last 56 rows are all for a single download.

@wiredfool

This comment has been minimized.

Copy link
Member

wiredfool commented Aug 18, 2019

I’m pretty sure that is just in there for the build artifacts on windows. I don’t think @cgohlke uses the winbuild bits for the actual releases.

@cgohlke

This comment has been minimized.

Copy link
Contributor

cgohlke commented Aug 18, 2019

Are those .exe installers something you normally send over each release day?

Those files are produced by my build script, which simply runs setup.py with bdist_wheel, bdist_egg, and bdist_wininst arguments for all supported CPython versions.

+1 for dropping bdist_wininst installers. According to PEP 527, PyPI should have stopped accepting uploads of bdist_wininst installers long ago (IIUC).

@hugovk hugovk merged commit 397a26b into python-pillow:master Sep 5, 2019
16 checks passed
16 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
python-pillow.Pillow Build #20190818.2 succeeded
Details
python-pillow.Pillow (Lint Python37) Lint Python37 succeeded
Details
python-pillow.Pillow (alpine) alpine succeeded
Details
python-pillow.Pillow (amazon_1_amd64) amazon_1_amd64 succeeded
Details
python-pillow.Pillow (amazon_2_amd64) amazon_2_amd64 succeeded
Details
python-pillow.Pillow (arch) arch succeeded
Details
python-pillow.Pillow (centos_6_amd64) centos_6_amd64 succeeded
Details
python-pillow.Pillow (centos_7_amd64) centos_7_amd64 succeeded
Details
python-pillow.Pillow (debian_10_buster_x86) debian_10_buster_x86 succeeded
Details
python-pillow.Pillow (debian_9_stretch_x86) debian_9_stretch_x86 succeeded
Details
python-pillow.Pillow (fedora_29_amd64) fedora_29_amd64 succeeded
Details
python-pillow.Pillow (fedora_30_amd64) fedora_30_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_16_04_xenial_amd64) ubuntu_16_04_xenial_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_18_04_bionic_amd64) ubuntu_18_04_bionic_amd64 succeeded
Details
@hugovk hugovk deleted the hugovk:rm-deprecated-bdist_wininst branch Sep 5, 2019
@aclark4life aclark4life added this to New Issues in Pillow Sep 12, 2019
@radarhere radarhere mentioned this pull request Sep 14, 2019
@nulano nulano mentioned this pull request Sep 24, 2019
18 of 19 tasks complete
@di di mentioned this pull request Oct 8, 2019
@radarhere

This comment has been minimized.

Copy link
Member

radarhere commented Mar 13, 2020

See also #2832 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pillow
  
New Issues
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.