Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy lint from Azure Pipelines to GitHub Actions #4058

Merged
merged 4 commits into from Sep 13, 2019

Conversation

@hugovk
Copy link
Member

commented Sep 11, 2019

Changes proposed in this pull request:

  • Move Copy the lint check from Azure Pipelines to GitHub Actions
  • Just a simple first step to show the similarity between AZP and GHA and check it's enabled

@hugovk hugovk added the Build label Sep 11, 2019

@hugovk hugovk referenced this pull request Sep 11, 2019

@aclark4life aclark4life added this to New Issues in Pillow Sep 12, 2019

@hugovk

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Closing and reopening to trigger Actions:

#4060

@hugovk hugovk closed this Sep 13, 2019

@hugovk hugovk reopened this Sep 13, 2019

@hugovk

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

I think it didn't trigger because it's set for push and not pull_request: 32789de. Will rebase.

@hugovk hugovk force-pushed the hugovk:add-github-actions-lint branch 2 times, most recently from a43cd6d to 96eb8a1 Sep 13, 2019

@hugovk hugovk force-pushed the hugovk:add-github-actions-lint branch from 96eb8a1 to f6eb0f7 Sep 13, 2019

@hugovk hugovk changed the title Move lint from Azure Pipelines to GitHub Actions Copy lint from Azure Pipelines to GitHub Actions Sep 13, 2019

@hugovk

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

GHA still not triggering. I've updated it to keep the lint in AZP, and will merge this to see if we need it in master to get off the ground.

@hugovk hugovk merged commit 929c817 into python-pillow:master Sep 13, 2019

15 of 16 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
python-pillow.Pillow Build #20190913.4 succeeded
Details
python-pillow.Pillow (Lint Python37) Lint Python37 succeeded
Details
python-pillow.Pillow (alpine) alpine succeeded
Details
python-pillow.Pillow (amazon_1_amd64) amazon_1_amd64 succeeded
Details
python-pillow.Pillow (amazon_2_amd64) amazon_2_amd64 succeeded
Details
python-pillow.Pillow (arch) arch succeeded
Details
python-pillow.Pillow (centos_6_amd64) centos_6_amd64 succeeded
Details
python-pillow.Pillow (centos_7_amd64) centos_7_amd64 succeeded
Details
python-pillow.Pillow (debian_10_buster_x86) debian_10_buster_x86 succeeded
Details
python-pillow.Pillow (debian_9_stretch_x86) debian_9_stretch_x86 succeeded
Details
python-pillow.Pillow (fedora_29_amd64) fedora_29_amd64 succeeded
Details
python-pillow.Pillow (fedora_30_amd64) fedora_30_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_16_04_xenial_amd64) ubuntu_16_04_xenial_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_18_04_bionic_amd64) ubuntu_18_04_bionic_amd64 succeeded
Details
@hugovk

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Working now! (sort of) https://github.com/python-pillow/Pillow/commit/929c817014834e3569b6c2d7112641b8a48da216/checks

Although not on this rebased PR: #4050

But it worked on my fork: hugovk#35

Adding pull_request looks good: #4061

@hugovk hugovk deleted the hugovk:add-github-actions-lint branch Sep 13, 2019

@hugovk hugovk referenced this pull request Sep 13, 2019

@hugovk hugovk added the Testing label Sep 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.