Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in coverage reports #4173

Merged
merged 6 commits into from Dec 2, 2019
Merged

Conversation

@hugovk
Copy link
Member

hugovk commented Oct 27, 2019

@hugovk hugovk added the Testing label Oct 27, 2019
@radarhere

This comment has been minimized.

Copy link
Member

radarhere commented Oct 28, 2019

Why omit check_*, but not 32bit_segfault_check, bench_*, import_all, make_hash, threaded_save or versions?

@hugovk

This comment has been minimized.

Copy link
Member Author

hugovk commented Oct 28, 2019

Good question. Let's review whether we still need them at all, can they be deleted? (I'm away from a computer for a few days, so can't check the git logs right now.)

@radarhere

This comment has been minimized.

Copy link
Member

radarhere commented Oct 29, 2019

Here is the history

  • 32bit_segfault_check.py - Added in #782. PR states 'Test is not run by default. Hangs when run through a testfixture.'
  • bench_cffi_access.py - Added in #476. Comment states 'Not running this test by default. No DOS against Travis CI.'
  • createfontdatachunk.py - See #789, moving it from a PIL __main__ to Scripts, and #2645, moving it from Scripts into Tests.
  • bench_get.py, import_all.py, make_hash.py, threaded_save.py, versions.py - Added in #35. Commit says 'This is Christoph Gohlke's test suite from his personal PIL package'
@hugovk

This comment has been minimized.

Copy link
Member Author

hugovk commented Nov 11, 2019

Here is the history

  • 32bit_segfault_check.py - Added in #782. PR states 'Test is not run by default. Hangs when run through a testfixture.'
  • bench_cffi_access.py - Added in #476. Comment states 'Not running this test by default. No DOS against Travis CI.'
  • createfontdatachunk.py - See #789, moving it from a PIL __main__ to Scripts, and #2645, moving it from Scripts into Tests.
  • bench_get.py, import_all.py, make_hash.py, threaded_save.py, versions.py - Added in #35. Commit says 'This is Christoph Gohlke's test suite from his personal PIL package'

@wiredfool @cgohlke Would you like to keep any of these files in repo?

@cgohlke

This comment has been minimized.

Copy link
Contributor

cgohlke commented Nov 11, 2019

bench_get.py, import_all.py, make_hash.py, threaded_save.py, versions.py - Added in #35. Commit says 'This is Christoph Gohlke's test suite from his personal PIL package'

Would you like to keep any of these files in repo?

No

@hugovk hugovk force-pushed the hugovk:cover-tests branch from c8c69d9 to 106fc40 Nov 20, 2019
hugovk added 2 commits Dec 2, 2019
@hugovk

This comment has been minimized.

Copy link
Member Author

hugovk commented Dec 2, 2019

  • 32bit_segfault_check.py - Added in #782. PR states 'Test is not run by default. Hangs when run through a testfixture.'
  • bench_cffi_access.py - Added in #476. Comment states 'Not running this test by default. No DOS against Travis CI.'
  • createfontdatachunk.py - See #789, moving it from a PIL __main__ to Scripts, and #2645, moving it from Scripts into Tests.

Let's keep them for now. Added to the ignore list.

  • bench_get.py, import_all.py, make_hash.py, threaded_save.py, versions.py - Added in #35. Commit says 'This is Christoph Gohlke's test suite from his personal PIL package'

Removed.

@radarhere radarhere merged commit 4551d3a into python-pillow:master Dec 2, 2019
50 checks passed
50 checks passed
Python 3.8
Details
ubuntu-latest Python pypy3
Details
alpine
Details
Python 3.5 x86
Details
ubuntu-latest Python 3.8
Details
arch
Details
Python 3.5 x64
Details
ubuntu-latest Python 3.7
Details
ubuntu-16.04-xenial-amd64
Details
Python 3.6 x86
Details
ubuntu-latest Python 3.6
Details
ubuntu-18.04-bionic-amd64
Details
Python 3.6 x64
Details
ubuntu-latest Python 3.5
Details
debian-9-stretch-x86
Details
Python 3.7 x86
Details
macOS-latest Python pypy3
Details
debian-10-buster-x86
Details
Python 3.7 x64
Details
macOS-latest Python 3.8
Details
centos-6-amd64
Details
Python 3.8 x86
Details
macOS-latest Python 3.7
Details
centos-7-amd64
Details
Python 3.8 x64
Details
macOS-latest Python 3.6
Details
amazon-1-amd64
Details
Python pypy3.6 x86
Details
macOS-latest Python 3.5
Details
amazon-2-amd64
Details
fedora-30-amd64
Details
fedora-31-amd64
Details
codecov/patch Coverage not affected when comparing f90a219...ce382e7
Details
codecov/project 89.6% (+4.9%) compared to f90a219
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
python-pillow.Pillow #20191202.5 succeeded
Details
python-pillow.Pillow (Lint Python37) Lint Python37 succeeded
Details
python-pillow.Pillow (alpine) alpine succeeded
Details
python-pillow.Pillow (amazon_1_amd64) amazon_1_amd64 succeeded
Details
python-pillow.Pillow (amazon_2_amd64) amazon_2_amd64 succeeded
Details
python-pillow.Pillow (arch) arch succeeded
Details
python-pillow.Pillow (centos_6_amd64) centos_6_amd64 succeeded
Details
python-pillow.Pillow (centos_7_amd64) centos_7_amd64 succeeded
Details
python-pillow.Pillow (debian_10_buster_x86) debian_10_buster_x86 succeeded
Details
python-pillow.Pillow (debian_9_stretch_x86) debian_9_stretch_x86 succeeded
Details
python-pillow.Pillow (fedora_30_amd64) fedora_30_amd64 succeeded
Details
python-pillow.Pillow (fedora_31_amd64) fedora_31_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_16_04_xenial_amd64) ubuntu_16_04_xenial_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_18_04_bionic_amd64) ubuntu_18_04_bionic_amd64 succeeded
Details
@hugovk hugovk deleted the hugovk:cover-tests branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.