Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various test changes #4357

Merged
merged 8 commits into from Jan 14, 2020
Merged

Various test changes #4357

merged 8 commits into from Jan 14, 2020

Conversation

@radarhere
Copy link
Member

radarhere commented Jan 14, 2020

Some commits simplifying test code, some commits adding new tests.

I think the only commits that need commentary are -

  • Removed print: Removes a print statement that doesn't look necessary or helpful
  • Removed unnecessary code: Removes code if __version__ contains 'rc'. Pillow doesn't use 'rc' versions.
@radarhere radarhere added the Testing label Jan 14, 2020
@wiredfool

This comment has been minimized.

Copy link
Member

wiredfool commented Jan 14, 2020

I’ve done rc versions in the past when I didn’t want to fill up with a .0.1 in a week due to breakage at the last minute.

@radarhere radarhere force-pushed the radarhere:testing branch from e0e0bea to 760bc7d Jan 14, 2020
@radarhere

This comment has been minimized.

Copy link
Member Author

radarhere commented Jan 14, 2020

Okay. Thanks for feedback, I've removed that commit.

@hugovk
hugovk approved these changes Jan 14, 2020
raise
res = im.resize(size, Image.LANCZOS, box)
self.assertEqual(res.size, size)
self.assert_image_equal(res, im.crop(box), ">>> {} {}".format(size, box))

This comment has been minimized.

Copy link
@homm

homm Jan 14, 2020

Member

👍

@radarhere radarhere merged commit a520a43 into python-pillow:master Jan 14, 2020
49 of 50 checks passed
49 of 50 checks passed
Python 3.8
Details
ubuntu-latest Python pypy3
Details
alpine
Details
Python 3.5 x86
Details
ubuntu-latest Python 3.8
Details
arch
Details
Python 3.5 x64
Details
ubuntu-latest Python 3.7
Details
ubuntu-16.04-xenial-amd64
Details
Python 3.6 x86
Details
ubuntu-latest Python 3.6
Details
ubuntu-18.04-bionic-amd64
Details
Python 3.6 x64
Details
ubuntu-latest Python 3.5
Details
debian-9-stretch-x86
Details
Python 3.7 x86
Details
macOS-latest Python pypy3 macOS-latest Python pypy3
Details
debian-10-buster-x86
Details
Python 3.7 x64
Details
macOS-latest Python 3.8
Details
centos-6-amd64
Details
Python 3.8 x86
Details
macOS-latest Python 3.7
Details
centos-7-amd64
Details
Python 3.8 x64
Details
macOS-latest Python 3.6
Details
centos-8-amd64
Details
Python pypy3.6 x86
Details
macOS-latest Python 3.5
Details
amazon-1-amd64
Details
amazon-2-amd64
Details
fedora-30-amd64
Details
fedora-31-amd64
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
python-pillow.Pillow Build #20200114.3 succeeded
Details
python-pillow.Pillow (Lint Python37) Lint Python37 succeeded
Details
python-pillow.Pillow (alpine) alpine succeeded
Details
python-pillow.Pillow (amazon_1_amd64) amazon_1_amd64 succeeded
Details
python-pillow.Pillow (amazon_2_amd64) amazon_2_amd64 succeeded
Details
python-pillow.Pillow (arch) arch succeeded
Details
python-pillow.Pillow (centos_6_amd64) centos_6_amd64 succeeded
Details
python-pillow.Pillow (centos_7_amd64) centos_7_amd64 succeeded
Details
python-pillow.Pillow (centos_8_amd64) centos_8_amd64 succeeded
Details
python-pillow.Pillow (debian_10_buster_x86) debian_10_buster_x86 succeeded
Details
python-pillow.Pillow (debian_9_stretch_x86) debian_9_stretch_x86 succeeded
Details
python-pillow.Pillow (fedora_30_amd64) fedora_30_amd64 succeeded
Details
python-pillow.Pillow (fedora_31_amd64) fedora_31_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_16_04_xenial_amd64) ubuntu_16_04_xenial_amd64 succeeded
Details
python-pillow.Pillow (ubuntu_18_04_bionic_amd64) ubuntu_18_04_bionic_amd64 succeeded
Details
@radarhere radarhere deleted the radarhere:testing branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.