Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ICNS save on all operating systems #4526

Merged
merged 27 commits into from Jun 30, 2021
Merged

Conversation

@newpanjing
Copy link
Contributor

@newpanjing newpanjing commented Apr 4, 2020

Changes proposed in this pull request:

  • Save as icns to support all operating systems
  • Removing the restriction that you can only use macOS
@radarhere radarhere changed the title Save in icns format to support all operating systems. Save in icns format to support all operating systems Apr 4, 2020
@radarhere
Copy link
Member

@radarhere radarhere commented Apr 7, 2020

Thanks very much. Is there documentation that you followed when writing this?

@radarhere radarhere changed the title Save in icns format to support all operating systems Allow ICNS save on all operating systems Jun 14, 2020
src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
Copy link
Member

@hugovk hugovk left a comment

Some minor suggestions

src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
radarhere and others added 2 commits Nov 1, 2020
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
radarhere and others added 3 commits Dec 30, 2020
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@BoboTiG
Copy link

@BoboTiG BoboTiG commented Mar 2, 2021

That would be a good thing! What is the status of the PR @newpanjing ?

hugovk
hugovk approved these changes Jun 28, 2021
src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
hugovk
hugovk approved these changes Jun 30, 2021
@hugovk hugovk merged commit 06f88dd into python-pillow:master Jun 30, 2021
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants