Fix issue 447 #503

Merged
merged 1 commit into from Mar 17, 2014

Conversation

Projects
None yet
2 participants
Member

manisandro commented Jan 25, 2014

Apparently some drivers only emit SANE_STATUS_EOF once, and SANE_STATUS_IO_ERROR after that. The code however assumed that the driver keeps emitting SANE_STATUS_EOF. This commit fixes this.

@manisandro manisandro Fix issue 447: Apparently some drivers only emit SANE_STATUS_EOF once…
…, and SANE_STATUS_IO_ERROR after that. The code however assumed that the driver keeps emitting SANE_STATUS_EOF. This commit fixes this.
8324a9a
Owner

aclark4life commented Mar 17, 2014

Sorry, can you update this PR? Getting a CI build failure: https://travis-ci.org/python-imaging/Pillow/builds/17621210

Member

manisandro commented Mar 17, 2014

The travis failure is not related to my change, the commit does not change anything related to eps files (which is where travis is stumbling). Do you need me to resubmit the PR to trigger a travis re-run or what should I do?

Owner

aclark4life commented Mar 17, 2014

I'll test local

@aclark4life aclark4life merged commit 8324a9a into python-pillow:master Mar 17, 2014

1 check failed

default The Travis CI build failed
Details
Owner

aclark4life commented Mar 17, 2014

And… we don't have any SANE tests anyway 😄. I'm going to merge this, but please consider writing a test or two or several to cover the SANE functionality.

Owner

aclark4life commented Mar 17, 2014

Fixes #447

Member

manisandro commented Mar 17, 2014

Doesn't look like a sane dummy backend exists, so tests would be kinda hard to implement without requiring the system to have a scanner attached :S

Owner

aclark4life commented Mar 17, 2014

Can you mock one?

Member

manisandro commented Mar 17, 2014

Uh, unfortunately I'm not really a sane expert, I've just used it in a project of mine and kinda know how to use it. But I found http://www.sane-project.org/man/sane-pnm.5.html which looks interesting, might give it a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment