Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PySide6 #5161

Merged
merged 2 commits into from Jan 1, 2021
Merged

Add support for PySide6 #5161

merged 2 commits into from Jan 1, 2021

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 30, 2020

Fixes #5145.

There are two sets of Python bindings for Qt, called PyQt and PySide.

Why are there two packages?

PyQt has been developed by Phil Thompson of Riverbank Computing Ltd. for a very long time — supporting versions of Qt going back to 2.x. Back in 2009 Nokia, who owned the Qt toolkit at the time, wanted to have Python bindings for Qt available under the LGPL license (like Qt itself). Unable to come to agreement with Riverbank (who would lose money from this, so fair enough) they then released their own bindings as PySide (also, fair enough).

https://www.learnpyqt.com/tutorials/pyqt5-vs-pyside2/

We support:

  • PySide2 for Qt 5
  • PyQt5 for Qt 5

Qt 6 has been recently released: https://www.qt.io/blog/qt-6.0-released

Changes proposed in this pull request:

  • Add support for PySide6. Take precedence over PyQt5 and PySide2, if they're also installed.
@radarhere
Copy link
Member

@radarhere radarhere commented Dec 31, 2020

Is it concerning that if I pip install PySide6, Ubuntu starts segfaulting? When I pip install PySide2, this is not what happens.

@hugovk
Copy link
Member Author

@hugovk hugovk commented Jan 1, 2021

It'll be missing dependencies for Ubuntu, for example we have libxcb-xinerama0 pyqt5-dev-tools for PyQt5.

I've created python-pillow/docker-images#102 to add PySide6 and its dependencies to the ubuntu-20.04-focal-amd64 image.

@radarhere
Copy link
Member

@radarhere radarhere commented Jan 1, 2021

Thanks

@radarhere radarhere merged commit f54ea8f into python-pillow:master Jan 1, 2021
49 of 50 checks passed
@hugovk hugovk deleted the add-pyside6 branch Jan 1, 2021
radarhere added a commit to radarhere/Pillow that referenced this issue Jan 1, 2021
hugovk added a commit that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants