Handle 32bit compiled python on 64bit architecture #521

Merged
merged 1 commit into from Mar 17, 2014

Conversation

Projects
None yet
3 participants
Contributor

choppsv1 commented Feb 11, 2014

platforma.processor() will return x86_64 on a 64 bit linux system;
however, this it wrong for 32 bit compiled python. By looking at
platform.architecture() first it correctly notes the 32bit
compile.

Handle 32bit compiled python on 64bit architecture
platforma.processor() will return x86_64 on a 64 bit linux system;
however, this it wrong for 32 bit compiled python. By looking at
platform.architecture() first it correctly notes the 32bit
compile.
Owner

wiredfool commented Feb 12, 2014

Interesting. I'd imagine that this is also an issue on Windows, as it's easy to get a 32 bit install on a 64 bit OS.

Are you testing this on a 32 bit linux + python install on 64 bit hardware, or a 32 bit python on a mixed 32/64 linux install?

aclark4life added a commit that referenced this pull request Mar 17, 2014

Merge pull request #521 from choppsv1/master
Handle 32bit compiled python on 64bit architecture

@aclark4life aclark4life merged commit fc9ad0a into python-pillow:master Mar 17, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

choppsv1 commented Mar 17, 2014

This was tested on 32-bit compiled python running on a x86_64 linux.

Owner

wiredfool commented on 2867d20 Mar 31, 2014

This breaks the build on 32bit PPC.

Contributor

choppsv1 replied Apr 1, 2014

What's the breakage?

Owner

wiredfool replied Apr 1, 2014

It sets the lib directory to /usr/lib/i386-linux-gnu for 32bit PPC builds. I suspect that it also breaks any non-x86 or x64 builds.

Can you check to see if dc16645 (or current master) still works for your mixed 32/64 bit case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment