Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only prefer command line tools SDK on macOS over default MacOSX SDK #5828

Merged
merged 2 commits into from Nov 12, 2021

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Nov 11, 2021

Resolves #5827

#5624 changed setup.py on macOS to prefer the command line tools SDK over xcrun --show-sdk-path. Apparently that was too far however, as conda-forge would like to specify the SDK path.

So instead, this PR scales back #5624 to only use the command line tools SDK when xcrun --show-sdk-path returns the default path of /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk

@hugovk
Copy link
Member

@hugovk hugovk commented Nov 11, 2021

build_extensions() is 500 lines long, shall we put this changed chunk into its own function?

@radarhere
Copy link
Member Author

@radarhere radarhere commented Nov 11, 2021

Ok, sure, done.

@h-vetinari
Copy link

@h-vetinari h-vetinari commented Nov 12, 2021

I tested this PR in conda-forge/pillow-feedstock#102, and it works fine! 🥳

Thanks a lot for the quick handling, much appreciated! :)

@hugovk
Copy link
Member

@hugovk hugovk commented Nov 12, 2021

Installs fine and tests pass for me on macOS Monterey 12.0.1 with defaults:

$  xcrun --show-sdk-path
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk

Thanks both!

The next scheduled release is 9.0.0 on 2nd January.

@hugovk hugovk merged commit 4fca3b4 into python-pillow:main Nov 12, 2021
48 of 49 checks passed
@radarhere radarhere deleted the macos_sdk_path branch Nov 12, 2021
@radarhere radarhere changed the title Only prefer command line tools SDK on macOS over the default Only prefer command line tools SDK on macOS over default MacOSX SDK Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants