Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected ICNS file length in header #5845

Merged
merged 1 commit into from Nov 21, 2021
Merged

Corrected ICNS file length in header #5845

merged 1 commit into from Nov 21, 2021

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Nov 20, 2021

Resolves #5590

https://en.wikipedia.org/wiki/Apple_Icon_Image_format#Header states that the second value is

Length of file, in bytes, msb first

Saving images pre-#4526, I find that this is the case.

Since that PR however, this is no longer the case. This PR fixes it and adds a test.

@hugovk hugovk merged commit 877d97e into python-pillow:main Nov 21, 2021
49 checks passed
@radarhere radarhere deleted the icns branch Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants