Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from deprecated "setup.py install" to "pip install ." #5896

Merged
merged 3 commits into from Dec 19, 2021

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Dec 18, 2021

Replaces setup.py install with pip install ., as per https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

As worked out by pypa/setuptools#2929, this also fixes the problem found in #5886. So this PR reverts #5886 and #5888.

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 18, 2021

Good stuff!

There's some setup.py develop as well, can they be pip install -e?

Also some setup.py build, setup.py build_ext and setup.py clean but they can wait.

@radarhere
Copy link
Member Author

@radarhere radarhere commented Dec 19, 2021

Ok, done.

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 19, 2021

Thanks!

@hugovk hugovk merged commit 0badf97 into python-pillow:main Dec 19, 2021
49 checks passed
@radarhere radarhere deleted the pip_install branch Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants