Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline fname2char to fix memory leak #6329

Merged
merged 1 commit into from Oct 29, 2022
Merged

Conversation

nulano
Copy link
Contributor

@nulano nulano commented May 24, 2022

Fixes #6319.

@nulano
Copy link
Contributor Author

nulano commented May 24, 2022

I'm not sure what happened with valgrind, but there are no errors reported for the modified file.

==328== More than 10000000 total errors detected.  I'm not reporting any more.
==328== Final error counts will be inaccurate.  Go fix your program!
==328== Rerun with --error-limit=no to disable this cutoff.  Note
==328== that errors may occur in your program without prior warning from
==328== Valgrind, because errors are no longer being displayed.

The two failed tests are clearly unrelated:

FAILED Tests/test_file_pdf.py::test_redos[\r] - Failed: Timeout >1.0s
FAILED Tests/test_file_pdf.py::test_redos[\n] - Failed: Timeout >1.0s

@wiredfool
Copy link
Member

I'm not surprised that the redos ones might have failed, because the timeouts are probably calibrated for an ordinary run, not the 10x slower valgrind run.

@radarhere
Copy link
Member

I've rerun valgrind and it is passing now.

@hugovk hugovk merged commit 327db9a into python-pillow:main Oct 29, 2022
60 of 62 checks passed
@nulano nulano deleted the imagetk-leak branch October 29, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in function fname2char due to new reference is not decreased (static analyzer report)
4 participants