Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload fribidi.dll to GitHub Actions #6532

Merged
merged 2 commits into from Oct 28, 2022
Merged

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Aug 24, 2022

Changes suggested:

@nulano nulano changed the title Upload fribidi.dll to GHA Upload fribidi.dll to GitHub Actions Aug 25, 2022
@radarhere
Copy link
Member

provide an alternative place to download an up-to-date fribidi.dll on GitHub Actions

An alternative to what? Is this something that cgohlke was providing?

@nulano
Copy link
Contributor Author

nulano commented Aug 25, 2022

cgohlke was providing a libraqm‑0.7.1.dll.zip, which contains both a libraqm.dll for older Pillow versions and a fribidi-0.dll for newer Pillow versions, as well as the relevant license files: libraqm-0.7.1.dll.zip

This PR adds a fribidi artifact to the GHA runs, containing just a fribidi.dll and its license: fribidi.zip

@radarhere
Copy link
Member

I've realised now this is connected to this part of the installation procedure.

Screen Shot 2022-10-03 at 9 49 36 am

@hugovk hugovk merged commit 7adda3d into python-pillow:main Oct 28, 2022
60 checks passed
@nulano nulano deleted the upload-fribidi branch October 28, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants