Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a warning if NumPy failed to raise an error during conversion #6594

Merged
merged 1 commit into from Oct 12, 2022

Conversation

radarhere
Copy link
Member

Resolves #6588

For NumPy < 1.23, if an error is raised when converting an image to a NumPy array, #6394 allowed NumPy to catch that, preventing the user from seeing it.

This PR will instead raise the error message as a warning.

@hugovk hugovk merged commit c2efd60 into python-pillow:main Oct 12, 2022
59 of 60 checks passed
@radarhere radarhere deleted the numpy branch October 12, 2022 10:58
@radarhere radarhere changed the title Raise a warning if NumPy will not raise an error during conversion Raise a warning if NumPy failed to raise an error during conversion Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pillow should require NumPy >= 1.23
2 participants