Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for opening WhiteIsZero 16-bit integer TIFF images #6642

Merged

Conversation

JayWiz
Copy link
Contributor

@JayWiz JayWiz commented Oct 5, 2022

just added a line to support 16 bit integer TIFFs. is kinda unusual, but this this is needed for custom generated TIFFs, e.g. if you're working with holograms or interferograms.

What did i do?

added a line in TiffImagePlugin.py to support 16 bit integer TIFFs

What did i expect to happen?

that Pillow is able to work with 16 bit integer TIFFs

What did actually happen?

Pillow is able to work with 16 bit integer TIFFs

What versions of Pillow and Python am i using?

Python 3.9 and Pillow 9.2.0

@radarhere radarhere changed the title added support for 16 bit integer tiffs Added support for 16 bit integer tiffs Oct 5, 2022
@radarhere radarhere changed the title Added support for 16 bit integer tiffs Added support for opening 16 bit integer TIFF Oct 5, 2022
src/PIL/TiffImagePlugin.py Outdated Show resolved Hide resolved
@radarhere
Copy link
Member

#3335 didn't add any TIFF-specific tests, so I don't think tests are needed here.

Feel free to say no, but would you be able to upload a copy of one such TIFF here, just in case we want to refer back to it in the future?

@radarhere radarhere changed the title Added support for opening 16 bit integer TIFF Added support for opening WhiteIsZero 16 bit integer TIFF Oct 5, 2022
@JayWiz
Copy link
Contributor Author

JayWiz commented Oct 5, 2022

#3335 didn't add any TIFF-specific tests, so I don't think tests are needed here.

Feel free to say no, but would you be able to upload a copy of one such TIFF here, just in case we want to refer back to it in the future?

yes of course, i'm fine with that. where should i upload it?

@radarhere
Copy link
Member

Just attach it to a comment here. I understand that GitHub won't let you attach a TIFF, so compress it into a zip first.

@JayWiz
Copy link
Contributor Author

JayWiz commented Oct 5, 2022

image_raw.zip

in case you're interested: this is a multipage tiff with 6 frames generated by two lasers, which can be reconstructed to this 3d point cloud. had to find a smaller tiff, usually one tiff is around 800 mb)
image

@radarhere
Copy link
Member

Thanks

@radarhere radarhere changed the title Added support for opening WhiteIsZero 16 bit integer TIFF Added support for opening WhiteIsZero 16 bit integer TIFFs Oct 6, 2022
@radarhere radarhere changed the title Added support for opening WhiteIsZero 16 bit integer TIFFs Added support for opening WhiteIsZero 16 bit integer TIFF images Oct 6, 2022
@radarhere radarhere merged commit 2942868 into python-pillow:main Oct 10, 2022
60 checks passed
@radarhere radarhere changed the title Added support for opening WhiteIsZero 16 bit integer TIFF images Added support for opening WhiteIsZero 16-bit integer TIFF images Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants