Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillow -> 5.4.1 #51

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Pillow -> 5.4.1 #51

merged 1 commit into from
Jan 7, 2019

Conversation

radarhere
Copy link
Member

No description provided.

@hugovk
Copy link
Member

hugovk commented Jan 6, 2019

Build failure:

=================================== FAILURES ===================================
____________________________ TestSanity.test_sanity ____________________________
self = <pytest_cov.plugin.CovPlugin object at 0x7f006c0f4e10>
item = <TestCaseFunction test_sanity>
    @compat.hookwrapper
    def pytest_runtest_call(self, item):
>       if (item.get_marker('no_cover')
                or 'no_cover' in getattr(item, 'fixturenames', ())):
E               AttributeError: 'TestCaseFunction' object has no attribute 'get_marker'
/vpy3/lib/python3.6/site-packages/pytest_cov/plugin.py:289: AttributeError

Pytest 4.1.0 has just been released, removing a number of features.

Could it be this?

pytest-dev/pytest#4546: Remove Node.get_marker(name) the return value was not usable for more than a existence check.

Use Node.get_closest_marker(name) as a replacement.

https://docs.pytest.org/en/latest/changelog.html#pytest-4-1-0-2019-01-05

@hugovk
Copy link
Member

hugovk commented Jan 6, 2019

Another project to run in to this (matplotlib/matplotlib#13121) notes it's an issue with pytest-cov: pytest-dev/pytest-cov#253.

If there's not a pytest-cov release soon, we can temporarily pin pytest<4.1, like matplotlib/matplotlib#13122.

@radarhere
Copy link
Member Author

pytest-cov 2.6.1 has been released. Re-running tests, this now passes.

@hugovk hugovk merged commit fc8255f into python-pillow:master Jan 7, 2019
@radarhere radarhere deleted the 5.4.1 branch January 7, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants