Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config directory if not exists #1248

Closed

Conversation

@pbzweihander
Copy link
Contributor

pbzweihander commented Jul 24, 2019

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!


Poetry seems to generate configuration file (config.toml) if not exists but does not make configuration directory (~/.config/pypoetry, for example).
So I think it would be great if poetry generates configuration directory, too.

@hadleyrich

This comment has been minimized.

Copy link

hadleyrich commented Jul 24, 2019

Neat, I was just about to make this pull request. Thanks!

@sdispater

This comment has been minimized.

Copy link
Member

sdispater commented Aug 2, 2019

This has been taken care of in #1272

Thanks nonetheless for taking the time to make this PR!

@sdispater sdispater closed this Aug 2, 2019
@pbzweihander pbzweihander deleted the pbzweihander:create-config-dir branch Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.