Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't exclude files that are explicit included in wheel (#1336) #1750

Merged
merged 1 commit into from Dec 24, 2019

Conversation

@finswimmer
Copy link
Member

finswimmer commented Dec 16, 2019

Explicit included files wasn't included in wheels if in excluding rule was there. This PR fixes it.

Fixes: #1336

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

@finswimmer finswimmer requested a review from python-poetry/core Dec 16, 2019
@finswimmer finswimmer added the Bug label Dec 23, 2019
Copy link
Member

sdispater left a comment

Looks good to me 👍

@sdispater sdispater merged commit dbe2c38 into python-poetry:master Dec 24, 2019
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
@sdispater

This comment has been minimized.

Copy link
Member

sdispater commented Dec 24, 2019

At some point, I think we will need to go over the masonry module and improve it because I think we can make the code more clear especially regarding exclusions and inclusions.

In the end, explicit includes should always take precedence over excludes.

shenek added a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.